Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move benchmark download tool and visualization to the CI #9075

Merged
merged 94 commits into from
Feb 28, 2024

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Feb 15, 2024

Closes #8857

Pull Request Description

Creates a new Benchmarks upload GitHub action that fetches all the latest benchmark results, and uploads them on the website hosted on https://github.com/enso-org/engine-benchmark-results repo. The results are stored in that repo in a bunch of JSON files.

Important Notes

The new Benchmarks upload action is scheduled to run after either "Engine benchmarks" or "Standard library benchmarks" jobs are complete.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • Revert 7dc9ed7
  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Akirathan Akirathan self-assigned this Feb 15, 2024
@Akirathan Akirathan force-pushed the wip/akirathan/8857-bench-on-ci branch from 5a5b9f3 to bc1f372 Compare February 19, 2024 14:43
@Akirathan Akirathan force-pushed the wip/akirathan/8857-bench-on-ci branch from 138f20e to 017a1e4 Compare February 27, 2024 09:18
@Akirathan Akirathan force-pushed the wip/akirathan/8857-bench-on-ci branch from 017a1e4 to 3f8b290 Compare February 27, 2024 09:20
@Akirathan
Copy link
Member Author

Please add ... to the template, so people can reference individual benchmarks on the page with an anchor: stdlib-benchs.html#org_enso_benchmarks_generated_Startup_hello_world_startup

@JaroslavTulach Good idea. Done in 7da61c7

@Akirathan
Copy link
Member Author

Akirathan commented Feb 28, 2024

The first successful run (that uploads the website) of the action is in https://github.com/enso-org/enso/actions/runs/8078775389?pr=9075

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@Akirathan
Copy link
Member Author

Akirathan commented Feb 28, 2024

After some experimentation, the last successful run is in https://github.com/enso-org/enso/actions/runs/8079939312/job/22075410072?pr=9075. I believe it is time to merge this PR, and remove the on: pull_request trigger.

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label Feb 28, 2024
@mergify mergify bot merged commit 3a3bef0 into develop Feb 28, 2024
26 of 27 checks passed
@mergify mergify bot deleted the wip/akirathan/8857-bench-on-ci branch February 28, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate benchmark result pages in the CI
4 participants